Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appdata: translate=no properties #3327

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yakushabb
Copy link
Contributor

@yakushabb yakushabb commented Mar 29, 2024

It appears that the appstream project no longer supports translatable=no properties, and gettext extract the translatable=no marked strings as translatable.

I opened an issue to inform about the situation, but translatable=no properties are not accepted by developers. You can find the issue here: ximion/appstream#623

Please test your script or string extraction process before merging this PR.

In MetaInfo files, each individual paragraph of a description
(or enumerated entry) is translated individually, however,
you can only exclude the complete block from being translated
by adding translate="no" to the description element.

Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html

Description

Please include a summary of the change and which issue is fixed (if available).
Please also include relevant motivation and context.

Type of change

  • Appdata related chore

It appears that the appstream project no longer supports
`translatable=no` properties, and gettext extract the
`translatable=no` marked strings as translatable.

I opened an issue to inform about the situation, but `translatable=no`
properties are not accepted by developers. You can find the issue
here: ximion/appstream#623

Also correct translatable usage.

**Please test your script or string extraction process
before merging this PR.**

> In MetaInfo files, each individual paragraph of a description
> (or enumerated entry) is translated individually, however,
> you can only exclude the complete block from being translated
> by adding `translate="no"` to the description element.

Source: https://freedesktop.org/software/appstream/docs/sect-Quickstart-Translation.html
Copy link

fab-sonarqube bot commented Mar 29, 2024

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yakushabb
Copy link
Contributor Author

@mirkobrombin

There are several strings from metainfo file appear translatable on Weblate. Could you review this PR when you have time. Thanks.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Pylint result on modfied files:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants